Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the trailing slash #2

Merged
merged 2 commits into from
Jun 11, 2016
Merged

Conversation

IonicaBizau
Copy link
Member

We can simply require(".") to require the current directory. 😁

@zeke
Copy link
Member

zeke commented Jun 11, 2016

No way! Wish I knew that a long time ago.

It will take me a lifetime to remove all those unneeded slashes from all my projects. :)

@zeke zeke merged commit 6ef37b2 into nice-registry:master Jun 11, 2016
@zeke
Copy link
Member

zeke commented Jun 11, 2016

Thanks @IonicaBizau. This change will roll out the next time the release script runs itself.

@IonicaBizau
Copy link
Member Author

@zeke Just create a script to replace and update that across the repos. 😄 It's probably something like :%s/\(('|")\.\./('|")\)/\('\.\.'\) and :%s/\(('|")\./('|")\)/\('\.'\).

Actually, if you like, I can do it for you. 😜

@zeke
Copy link
Member

zeke commented Jun 11, 2016

Actually, if you like, I can do it for you. 😜

Be my guest!

@IonicaBizau
Copy link
Member Author

@zeke Done. 🚀 🎉

Probably I spammed you with few emails, but for convenience, check this out: https://github.com/pulls?utf8=✓&q=is%3Aopen+is%3Apr+author%3AIonicaBizau+user%3Azeke

Some of the tests are failing, but most probably because .travis.yml is missing.

This is the magic command:

sed -i -e "s/require(\"\.\/\")/require\(\'\.\'\)/g" *.js && rm *.js-e && git commit -m 'Removed trailing slash' . && git push --all

@IonicaBizau IonicaBizau deleted the slash branch June 12, 2016 07:40
@zeke
Copy link
Member

zeke commented Jun 13, 2016

@IonicaBizau you are a wizard. Thanks so much! I had forgotten about half those projects. 🙈

@IonicaBizau
Copy link
Member Author

@zeke Cool! You're welcome. 😁 I update mine each few months, automagically (especially keeping the README.md files to follow the same template). 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants